Skip to content

Remove the use of an external css file #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

Remove the use of an external css file #904

merged 1 commit into from
Aug 15, 2022

Conversation

@rizwan3d
Copy link
Contributor

@rizwan3d rizwan3d commented Aug 15, 2022

resolves #899

@driesvints
Copy link
Member

driesvints commented Aug 15, 2022

Thanks @rizwan3d. Does this looks good to you @tvbeek?

@tvbeek
Copy link
Contributor

tvbeek commented Aug 15, 2022

Thanks @rizwan3d. Does this looks good to you @tvbeek?

I personal prefer not to depend on loading any css / font from an external site on the other hand I understand that you don't want to host it local.

In that case I think this is already an improvement 👍

@driesvints driesvints merged commit 56dda1c into laravelio:main Aug 15, 2022
@driesvints
Copy link
Member

driesvints commented Aug 15, 2022

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove the use of an external css file

3 participants

@rizwan3d @driesvints @tvbeek